[GNOME] Fix audio/video filters for mime types in Nautilus

Issue 2452 reported a bug on Nautilus where, given a directory with a bunch of audio/video files, when applying those filters, the files would not show up. This issue was reported 2 years prior to this contribution and was actually solved at the time.

The issue

On the nautilus-mime-actions.c file, the mime types are actually defined inside Nautilus. Those types actually reflect the types of files that can be filtered using the filter tool.

The filter tool on Nautilus

The solution was actually proposed by the issue reporter, and then the code was put there by one of the mantainers, but the merge request got lost and never finished. To that’s when I saw that it would be an easy issue to fix and not much was actually necessary.

How the interaction went

Given the situation on this issue, I decided to leave a comment asking if this was never merged, as I suspected, but there were some weird climax by the guy who reported the issue towards the mantainers. I will probably remove this later on from the post, but he resented the mantainers for not merging and fixing his solution, and came with many negative comments. On the opposite side, one of the mantainers cleared me to just fix the conflicts and pull his commit to the main branch.

First comment screenshot

Second comment screenshot

Third comment screenshot

What we did

Since this was already done, we had no trouble adjusting it for merge purposes. We knew what file we had to deal with, so we just cherry-picked the commit that proposed the changes and applied it to the main branch. The only work left to do was dealing with the conflicts and then it was all set to a new commit.

With all that done, we sent the merge request and, after one of the mantainers adding a new file type to the filters, it got accepted and we now have our first merge request ever on GNOME. Even though it was a nobrainer, it felt really good contributing for the first time to a project that affects millions of people all over the world :)

Our MR on the top of the list

This post is used as a checkpoint on GNOME contributions, first started as an assignment on the Open Source development class, at the Institute of Mathematics and Statistics of the University of São Paulo, advised by professor Paulo Meirelles.